DM-21454: Include all column names in foreign key names. #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the easiest way to ensure unique foreign key names.
andy-slac
reviewed
Sep 30, 2019
| @@ -305,9 +305,10 @@ def toSqlAlchemy(self, tableName: str, schema: Schema) -> ForeignKeyConstraint: | |||
| constraint : `sqlalchemy.ForeignKeyConstraint` | |||
| SQLAlchemy version of the foreign key constraint. | |||
| """ | |||
| name = "_".join(["fkey", tableName, self.table] + list(self.target) + list(self.source)) | |||
There was a problem hiding this comment.
I think this has a potential to exceed name size limits for some backends.
There was a problem hiding this comment.
I'm a bit worried about that, too, but @MichelleGower hasn't reported any problems in her tests yet, and I don't think we can guarantee a unique name without including all of these terms, even if they aren't usually necessary. Given that this isn't really a useful-visible name (except maybe in some pretty low-level debugging contexts), I think the next step is probably trying to hash these terms into something with fixed size, and I'd rather not do that on this ticket.
There is an abstract filter called "UNRECOGNISED" in table PHYSICAL_FILTER which was longer than the column width. Increased the column width from 8 to 16.
|
With these changes and a newer version of SQLAlchemy, I was able to run ci_hsc_gen3 with Oracle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the easiest way to ensure unique foreign key names.