DM-21748: Fixes for Oracle MERGE implementation #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichelleGower
approved these changes
Oct 15, 2019
The _Merge class has to inherit Executable so that Connection can execute it, the order of base classes for _Merge is important. Call to bindparam() in generated MERGE needs a `type_` argument to correctly interpret parameter data using all registered type decorators.
andy-slac
force-pushed
the
tickets/DM-21748
branch
from
7da68d1
to
1d0c2db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _Merge class has to inherit Executable so that Connection can
execute it, the order of base classes for _Merge is important. Call to
bindparam() in generated MERGE needs a
type_argument to correctlyinterpret parameter data using all registered type decorators.