DM-22364: Allow makeRepo returned Config to be used to create Butler #208
Conversation
timj
force-pushed
the
tickets/DM-22364
branch
from
7c5e34c
to
2c20f6b
Compare
This is important if a Config is created from another Config.
timj
force-pushed
the
tickets/DM-22364
branch
from
2c20f6b
to
353cca4
Compare
There was a problem hiding this comment.
I can't say I fully understand what's going on inside Config here, except for the fact that it looks like copy construction was previously skipping a key attribute. I'm a little concerned that we apparently treat named config files differently from in-memory config objects (in that we remember their filenames and that's apparently important), and would appreciate an explanation of that, but certainly don't think it should get in the way of what's an obvious improvement.
| # None or empty string indicate a problem | ||
| if not butlerRoot: | ||
| raise ValueError(f"Required to replace {BUTLER_ROOT_TAG} in '{configRoot}' " | ||
| "but a replacement has not been defined") |
There was a problem hiding this comment.
Can you think of any way a common high-level operation would get to this error? If so, we may want to beef up the error message with a guess about what might have gone wrong, but I'm guessing the other changes on this ticket mean it's hard to imagine how this might happen, and that's fine too.
No description provided.