DM-22677: Relocate scripts to python module #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-22677
branch
from
e20e290
to
838db10
Compare
TallJimbo
approved these changes
Dec 21, 2019
| print(config, file=outfh) | ||
|
|
||
|
|
||
| def main(): |
There was a problem hiding this comment.
Would it be worthwhile having this take an args to pass to parse_args() that would take sys.argv[1:] or similar? That seems like it's a missing piece of making this more usable, but I also don't really a scenario where we'd actually use that.
There was a problem hiding this comment.
I believe I'm following standard practice here: https://developer.lsst.io/stack/argparse-script-topic-type.html?highlight=autoprogram
| Note | ||
| ---- | ||
| Notes | ||
| ----- |
There was a problem hiding this comment.
I think I've also got this fix on a branch for you to review 🙂 .
Exceptions lead to bad exit status anyhow so there is no need to catch the exception just to return a bad exit status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.