DM-22648: Add DcrModel to Gen3 butler #220
Conversation
| @@ -8,5 +8,5 @@ datastore: | |||
| # valid_first and valid_last here are YYYYMMDD; we assume we'll switch to | |||
| # MJD (DM-15890) before we need more than day resolution, since that's all | |||
| # Gen2 has. | |||
| default: "{collection}/{datasetType}.{component:?}/{tract:?}/{patch:?}/{label:?}/{abstract_filter:?}/{physical_filter:?}/{visit:?}/{datasetType}_{component:?}_{tract:?}_{patch:?}_{label:?}_{abstract_filter:?}_{physical_filter:?}_{calibration_label:?}_{visit:?}_{exposure:?}_{detector:?}_{instrument:?}_{skymap:?}_{skypix:?}_{run}" | |||
| default: "{collection}/{datasetType}.{component:?}/{tract:?}/{patch:?}/{label:?}/{abstract_filter:?}/{subfilter:?}/{physical_filter:?}/{visit:?}/{datasetType}_{component:?}_{tract:?}_{patch:?}_{label:?}_{abstract_filter:?}_{physical_filter:?}_{calibration_label:?}_{visit:?}_{exposure:?}_{detector:?}_{instrument:?}_{skymap:?}_{skypix:?}_{run}" | |||
There was a problem hiding this comment.
As you change this do you mind changing the default in config/datastores/s3Datastore.yaml as well? (I know... the duplication is not ideal... :(
There was a problem hiding this comment.
Thank you for catching this!
isullivan
force-pushed
the
tickets/DM-22648
branch
3 times, most recently
from
fee78a0
to
08d98df
Compare
config/dimensions.yaml
Outdated
| - | ||
| name: name | ||
| type: string | ||
| length: 8 |
There was a problem hiding this comment.
So, this is number of characters, if someone has a longish abstract filter name, or I guess if you have a crazy number of sub-bands you could run over this. Might be worth adding a check in the script that adds subbands to make sure the name is under 8 characters
There was a problem hiding this comment.
We already set abstract_filter to 16 so you need to be at least that long (and probably bigger). Or is this string an addendum to abstract_filter that is guaranteed to be < 8?
There was a problem hiding this comment.
This should typically be abstract_filter plus two more characters.
isullivan
force-pushed
the
tickets/DM-22648
branch
from
08d98df
to
5410bc8
Compare
Should be merged at the same time as DM-23008, and before DM-21917.
The
subfilterdimension is used for modeling chromatic effects such as Differential Chromatic Refraction in coadds.