DM-22776: Update Gen3 isrTask for BF corrections #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natelust
approved these changes
Jan 29, 2020
| @@ -140,6 +140,8 @@ storageClasses: | |||
| pytype: numpy.ndarray | |||
| StrayLightData: | |||
| pytype: lsst.ip.isr.StrayLightData | |||
| BrighterFatterKernel: | |||
| pytype: lsst.cp.pipe.makeBrighterFatterKernel.BrighterFatterKernel | |||
There was a problem hiding this comment.
Do you need to make a formatter for this?
There was a problem hiding this comment.
I have added an entry to config/datastores/formatters.yaml to be safe. The test I ran ingested a BrighterFatterKernel from the gen2 butler, and that explicitly required a formatter entry (and so didn't cause any issues)
czwa
force-pushed
the
tickets/DM-22776
branch
2 times, most recently
from
f0c01b2
to
5e9920f
Compare
czwa
force-pushed
the
tickets/DM-22776
branch
from
5e9920f
to
b912383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add BrighterFatterKernel storageClass.