DM-13869: Implement basic Registry.find and related functionality #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pschella
force-pushed
the
tickets/DM-13869
branch
from
a6c5730
to
965952f
Compare
added 9 commits
March 21, 2018 21:01
This really is just a bare-bones starting point. Does no lookup based on unit values and thus can only handle one dataset per collection. This is of course utterly useless except for building on.
pschella
force-pushed
the
tickets/DM-13869
branch
from
965952f
to
3857fbe
Compare
|
I'd be wary of running autopep8 on the entire code base when we know we are already flake8 clean. |
timj
approved these changes
Mar 22, 2018
|
Running autopep8 is my lazy way of being flake8 compatible (at least for the multi-line sql annoyance). But I'll stop running it on a non-file-to-file basis now. |
|
Can you enable flake8 checking in your editor? It's just I'm worried about autopep8 fiddling with things that currently are fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.