DM-23503: Deal with / in dataId values in file templates #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "/" format specifier disables this.
collection comes first so there is no problem allowing it to generate extra directories. / is not allowed un the run at the end of the template.
TallJimbo
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
Looks good.
As a heads-up, I was planning to drop support for "collection" as a placeholder on DM-21849 (6f6a125 now, though I'm sure I'll rebase before I'm done) - it's already a synonym for "run", and after RFC-663 I think it'll be more confusing than convenient. Not anything you need to do anything about now, but I thought I'd mention it as potentially related.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the templates would create extra unexpected directories.