DM-23711: Support shell variables in includeConfigs directive #234
Conversation
There was a problem hiding this comment.
Looks good. I don't suppose you can easily do anything about this either way (except maybe document it), but do you know if expandvars will complain if referenced envvars don't exist, vs. just expanding them to "", the way shells typically (and unfortunately!) do?
|
It's documented to leave the variable in there untouched. Given that this is only used for reading configs you immediately get a big complaint about the file not being found. |
|
I think complaining about that is a fairly obvious indicator of a problem since it will report the file name that includes the |
|
If you really want I can check for the presence of a |
|
No need for special checking. Leaving the var untouched should be enough of a diagnostic; I'm just glad it doesn't do what the shell does, as that has a much better chance of resolving to something incorrect that might exist. |
No description provided.