DM-23718: Replace dots in file templates with underscore

[timj]

Sometimes physical_filter definitions include spaces and it's
much easier to use a file name if spaces are not there.

[parejkoj]

@timj : you technically can't be a reviewer of this because you created it, but can you please take a look? I'll leave it to you to update the ticket and PR description.

We should probably squash these two commits together?

I'm concerned about any effects this may have downstream if there are templates in use that are only basename that have '.' in them.

[timj]

You mean you are worried about a template that refers to the special . directory but has no file component at all? A template that has no file in it is going to break.

[parejkoj]

The other way around: a template that has no / in it at all (and thus no directory, just basename).

[timj]

We can trap a template that ends in a /

[timj]

This doesn’t affect existing files in data stores. Only future ones.

[timj]

Looks good. Yes squash since we aren't doing the space replacement.

[timj]

@parejkoj use git commit --amend --author "..." to update the author of the commit you just squashed so it's not me.