DM-24290: PostgreSQL database handles case when namespace is not provided incorrectly. #247
Conversation
DinoBektesevic
changed the title
DinoBektesevic
force-pushed
the
tickets/DM-24290
branch
from
6296aa9
to
140d1b9
Compare
DinoBektesevic
force-pushed
the
tickets/DM-24290
branch
from
ba1a6e1
to
5936f68
Compare
There was a problem hiding this comment.
(Trivial) Registry changes look good to me, and I've only quickly scanned the rest - I'm happy to leave it to you and @timj to work out the URI handling, since I historically haven't followed that closely and would need to spend some time getting up to speed on it to understand the subtleties.
DinoBektesevic
force-pushed
the
tickets/DM-24290
branch
from
5936f68
to
448cb69
Compare
DinoBektesevic
force-pushed
the
tickets/DM-24290
branch
2 times, most recently
from
39f2c90
to
ec0451f
Compare
DinoBektesevic
force-pushed
the
tickets/DM-24290
branch
2 times, most recently
from
55472d0
to
bdae5d9
Compare
|
After talking with Tim it was decided a clearer way than the Extra handling of weird edge-cases added. This finally allows for |
DinoBektesevic
force-pushed
the
tickets/DM-24290
branch
from
020817e
to
749a72b
Compare
Maybe I'm just slightly confused as to how are fragments meant to be used if we're missing the basename of the URI, but here are the desired changes. I thought magically expanding head value might be confusing when compared to |
DinoBektesevic
force-pushed
the
tickets/DM-24290
branch
2 times, most recently
from
0fdb749
to
078d938
Compare
When creating Keys in AWS S3 only keys ending with '/' will appear and behave as directories. Thus, there is a difference between inserting `/abs/dir` and `/abs/dir/` keys into a Bucket. This affects creation of Datastore roots and Butler.makeRepo functionality which will then create non-intuitive paths in S3. Added dirLike attribute to ButlerURI. Attribute tracks whether the ButlerURI ends with a separator or not. Added forceDirectory argument to ButlerURI. When set to True it will force a trailing separator to exist. Forced LocationFactory, Butler.makeRepo and Location datastoreRootUri argument to always forceDirectory. These are places where we *know* that the given string *must* be a directory. Rearranged the Location testButlerUri cases because they were hard to keep track of. Added explicit additional check on whether a Bucket exists in Butler.makeRepo. Now raising a ValueError that the bucket doesn't exist. Moved setting of Config.configFile to __initFromFile from __initFromYamlFile.
Removed empty newline and unwanted comments.
Updated all templates in tests/config from '{run}' to '{run:/}'.
Add missing empty line in test_location.
Correctly propagating butlerRoot for S3Datastore required inovative use of butler.updateFile in less-than-intuitive ways. ButlerURI split works the same way as os.path.split does and returns the base and dir names. This simplifies and makes logic checking whether an URI points to a config file more expressive. Added ButlerURI.split method, equivalent to os.path.split. Added ButlerURI.dirname method, equivalent to os.path.dirname. Added ButlerURI.basename method, equivalent to os.path.basename. Added tests for ButlerURI.split. Handling of edgecases such as empty paths and "." improved.
DinoBektesevic
force-pushed
the
tickets/DM-24290
branch
from
078d938
to
ee2c6b9
Compare
Solves issue described in DM-24290 point 1.a when namespace is not provided it is set to an non-existent DSN "schema" key. Went unnoticed because all the tests provide explicit namespace arguments.