DM-13403: numpy types fail in butler dataIds #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least one database backend cannot handle `numpy.int64` type which is a subclass of `numbers.Integral`. This patch replaces all values of Integral type in a DataCoordinate with ints.
TallJimbo
approved these changes
Apr 2, 2020
There was a problem hiding this comment.
Looks good. I approve of DataCoordinate.standardize as the place to put this - while there may be other ways one could pass numpy types into the database, that will cover all data IDs (and hence the vast majority of places one is likely to pass a numpy type), and it might save us from non-database trouble with instance(numpy.int64, int) being False in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least one database backend cannot handle
numpy.int64type which isa subclass of
numbers.Integral. This patch replaces all values ofIntegral type in a DataCoordinate with ints.