DM-24314: Read through symlinks when ingesting as symlinks #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents us from having a repository that has multiple indirections to the real dataset.
kfindeisen
approved these changes
Apr 2, 2020
|
Yes, obs packages are where a lot of the ingest stuff happens. I'll take a look to see if the butler ingest tests of symlink can be modified to make a double symlink. |
kfindeisen
reviewed
Apr 3, 2020
tests/test_datastore.py
Outdated
Comment on lines
464
to
472
| os.symlink(os.path.abspath(realpath), sympath) | ||
| datastore = self.makeDatastore() | ||
| datastore.ingest(FileDataset(path=os.path.abspath(sympath), refs=ref), transfer=mode) | ||
| uri = ButlerURI(datastore.getUri(ref)) |
There was a problem hiding this comment.
Consider adding blank lines as follows:
Suggested change
| os.symlink(os.path.abspath(realpath), sympath) | |
| datastore = self.makeDatastore() | |
| datastore.ingest(FileDataset(path=os.path.abspath(sympath), refs=ref), transfer=mode) | |
| uri = ButlerURI(datastore.getUri(ref)) | |
| os.symlink(os.path.abspath(realpath), sympath) | |
| datastore = self.makeDatastore() | |
| datastore.ingest(FileDataset(path=os.path.abspath(sympath), refs=ref), transfer=mode) | |
| uri = ButlerURI(datastore.getUri(ref)) |
I think that would make it easier to follow the logic (setup, operation being tested, tests).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents us from having a repository that has multiple indirections to the real dataset.