DM-24375: Fix time precision issue in type decorator #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
Apr 8, 2020
timj
approved these changes
Apr 9, 2020
andy-slac
force-pushed
the
tickets/DM-24375
branch
2 times, most recently
from
9bd8c7f
to
2ae2cad
Compare
Precision of a Python float type is not enough to guarantee nanosecond precision, need more careful handling when converting between astropy time and nanoseconds.
Move time conversion methods from `ddl` to new module `time_utils`, add time comparison with precision. Should make it more reusable.
andy-slac
force-pushed
the
tickets/DM-24375
branch
from
2ae2cad
to
9bf1f21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precision of a Python float type is not enough to guarantee nanosecond
precision, need more careful handling when converting between astropy
time and nanoseconds.