DM-24658: Improve error reporting in connection string. #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DinoBektesevic
force-pushed
the
tickets/DM-24658
branch
3 times, most recently
from
a19d6a5
to
ca75f16
Compare
ktlim
approved these changes
Apr 29, 2020
Relocate dbAuth and connectionString tests to a common location. Unify dbAuth and connectionString tests files and remove duplicates. Use more explicit test file names. Fix tests (paths and expected results). Fix bad permissions.
…onnection string and fix type in registryConf2.yaml.
DinoBektesevic
force-pushed
the
tickets/DM-24658
branch
from
3443f5b
to
970f92a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop silencing
DbAuthErrorwhen cause is a YAML parsing issue.Reorganize dbAuth and connectionString test files, simplify and de-duplicate.
Add test to ensure error propagates through ConnectionString class .