Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-24560: make 'repo' an argument, by convention always the first. #272

Merged
merged 2 commits into from May 4, 2020

Conversation

n8pease
Copy link
Contributor

@n8pease n8pease commented May 4, 2020

No description provided.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay although we have to be careful about path vs URI.

text). By default the value of repo_argument.existing_repo.
"""

will_create_repo = "REPO is a filesystem path for the new repository. " \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a URI to the new butler root. It doesn't have to be a filesystem path.


will_create_repo = "REPO is a filesystem path for the new repository. " \
"Will be created if it does not exist."
existing_repo = "REPO is the path to an existing data repository root " \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a URI to an existing repository root or configuration file. Does not have to be a path.

@n8pease n8pease merged commit bd3b2c3 into master May 4, 2020
@timj timj deleted the tickets/DM-24560 branch May 17, 2020 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants