DM-13963: Enable foreign_key integrity checking on Butler SqlRegistry #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
Apr 2, 2018
| @@ -21,7 +21,11 @@ | |||
|
|
|||
| import itertools | |||
|
|
|||
| from sqlite3 import Connection as SQLite3Connection | |||
There was a problem hiding this comment.
Any chance we could have the sqlite knowledge in a subclass?
There was a problem hiding this comment.
We probably should. But I'm not sure we want to do that right now?
There was a problem hiding this comment.
would it be anything other than copying 20 lines to another file and changing the registry name in the yaml file?
| def _enableForeignKeysOnSqlite3(dbapiConnection, connectionRecord): | ||
| if isinstance(dbapiConnection, SQLite3Connection): | ||
| cursor = dbapiConnection.cursor() | ||
| cursor.execute("PRAGMA foreign_keys=ON;") |
There was a problem hiding this comment.
Do you need a try/finally here to ensure that cursor.close() is called? Or the internet gives the alternative form of:
from contextlib import closing
with closing(self.connection.cursor()) as cur:
pschella
force-pushed
the
tickets/DM-13963
branch
from
f9239ca
to
294c917
Compare
added 3 commits
April 2, 2018 15:33
This is required because Registry.addStorageInfo enforces its foreign-key relation with Registry.addDataset (which we don't want to have to do in the Datastore only tests).
pschella
force-pushed
the
tickets/DM-13963
branch
from
294c917
to
a4a7337
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.