DM-24807: Add type annotations to datastore #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-24807
branch
3 times, most recently
from
7ade7b4
to
e209181
Compare
timj
commented
May 15, 2020
TallJimbo
approved these changes
May 16, 2020
| @@ -667,12 +687,13 @@ def export(self, refs: Iterable[DatasetRef], *, | |||
| raise NotImplementedError(f"Transfer mode {transfer} not supported.") | |||
|
|
|||
| @abstractmethod | |||
| def validateConfiguration(self, entities, logFailures=False): | |||
| def validateConfiguration(self, entities: Iterable[Union[DatasetRef, DatasetType, StorageClass]], | |||
| logFailures: bool = False) -> None: | |||
There was a problem hiding this comment.
"Entity" might merit an alias.
This simplifies the case where we only want the refs for a single ref. Also makes type annotations easier.
Rather than using __post_init__ (which is very hard to use type annotations with) instead force the dataclass to be frozen but also replace with our own __init__
A mutable list is not what we wanted for something that should not be changed by the caller.
Also added annotations for related classes called by datastores. Mypy has been enabled for some core classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.