Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-24851: Add getURIs method #288

Merged
merged 8 commits into from
May 20, 2020
Merged

DM-24851: Add getURIs method #288

merged 8 commits into from
May 20, 2020

Commits on May 20, 2020

  1. Add getURIs to return multiple URIs for a single dataset 

    Currently getUri is implemented using getURIs and still
returns a string.
    @timj
    timj committed May 20, 2020
    Configuration menu
    Copy the full SHA
    c4b5b37 View commit details
    Browse the repository at this point in the history

  2. Add ButlerURI repr and __eq__

    @timj
    timj committed May 20, 2020
    Configuration menu
    Copy the full SHA
    ee9e333 View commit details
    Browse the repository at this point in the history

  3. Add more information to In-Memory datastore URIs

    @timj
    timj committed May 20, 2020
    Configuration menu
    Copy the full SHA
    7dc0456 View commit details
    Browse the repository at this point in the history

  4. Change getUri to getURI and change return value to ButlerURI 

    Name change matches getURI and since we are breaking the return
value (no longer str) safer to explicitly break an downstream
code.
    @timj
    timj committed May 20, 2020
    Configuration menu
    Copy the full SHA
    6e3832b View commit details
    Browse the repository at this point in the history

  5. Ensure that predicted URI takes into account disassembly

    @timj
    timj committed May 20, 2020
    Configuration menu
    Copy the full SHA
    ad7b7cf View commit details
    Browse the repository at this point in the history

  6. Use consistent error message for getURI if multiple URIs retrieved

    @timj
    timj committed May 20, 2020
    Configuration menu
    Copy the full SHA
    63623ff View commit details
    Browse the repository at this point in the history

  7. Add type annotations for Constraints

    @timj
    timj committed May 20, 2020
    Configuration menu
    Copy the full SHA
    5de8def View commit details
    Browse the repository at this point in the history

  8. Add type annotations to mappingFactory 

    Some of the annotations have to be a bit loose because
we are allowing "objects that have a .name method"
    @timj
    timj committed May 20, 2020
    Configuration menu
    Copy the full SHA
    aa808a7 View commit details
    Browse the repository at this point in the history