Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-25153: Remove _ components from class path name when determining full type name #294

Merged
merged 2 commits into from May 29, 2020
Merged

DM-25153: Remove _ components from class path name when determining full type name #294

merged 2 commits into from May 29, 2020

Conversation

timj
Copy link
Member

@timj timj commented May 29, 2020

No description provided.

TallJimbo
TallJimbo approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Makes me really want to go rename daf.butler.core -> daf.butler._core (and probably more), but I'll resist that urge, at least until I have a real reason to.

python/lsst/daf/butler/core/utils.py Outdated Show resolved Hide resolved
TallJimbo
TallJimbo approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes look good!

@timj timj merged commit a8c5c3a into master May 29, 2020
@timj timj deleted the tickets/DM-25153 branch May 29, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @TallJimbo