Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-25187: fix breakage in doc build #299

Merged
merged 2 commits into from Jun 2, 2020
Merged

DM-25187: fix breakage in doc build #299

merged 2 commits into from Jun 2, 2020

Conversation

TallJimbo
Copy link
Member

No description provided.

These aren't our own classes - they're aliases to standard library
types that aren't exposed in a mypy-friendly way.  Sphinx has a hard
time processing, presumably because of the conditional definition that
makes them appear different to mypy.
Copy link
Contributor

@ktlim ktlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@TallJimbo TallJimbo force-pushed the tickets/DM-25187 branch 6 times, most recently from 7eb266d to 28e55da Compare June 2, 2020 15:13
@TallJimbo TallJimbo merged commit 74c33e1 into master Jun 2, 2020
@TallJimbo TallJimbo deleted the tickets/DM-25187 branch June 2, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants