Remove ill-conceived data ID consistency checking. #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-25246
branch
2 times, most recently
from
c4d6a0e
to
418b8e6
Compare
The only code that used this was in QuantumGraph generation in pipe_base, and that's already been replaced to improve performance. More importantly, the parts of this that involved spatial and temporal consistency never made sense - we have clear use cases where the naive intersection relationships the butler uses by default for these aren't appropriate (e.g. jointcal), and I should have realized earlier that this code didn't leave room for them.
TallJimbo
force-pushed
the
tickets/DM-25246
branch
from
418b8e6
to
1d38cab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only code that used this was in QuantumGraph generation in pipe_base, and that's already been replaced to improve performance.
More importantly, the parts of this that involved spatial and temporal consistency never made sense - we have clear use cases where the naive intersection relationships the butler uses by default for these aren't appropriate (e.g. jointcal), and I should have realized earlier that this code didn't leave room for them.