Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-14139: Implement Registry.ensureRun on Gen3 Butler #32

Merged
merged 1 commit into from Apr 20, 2018

Conversation

pschella
Copy link
Collaborator

No description provided.

Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One micro-comment.

def ensureRun(self, run):
"""Conditionally add a new `Run` to the `SqlRegistry`.

If the ``run.id`` is ``None`` or a `run` with this `id` doesn't exist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize second occurrence of run?

@pschella pschella merged commit 2c05c62 into master Apr 20, 2018
@ktlim ktlim deleted the tickets/DM-14139 branch August 25, 2018 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants