DM-25881: Add extra logging to S3 datastore #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
Jul 9, 2020
| self.client.put_object(Bucket=location.netloc, Key=location.relativeToPathRoot, | ||
| Body=serializedDataset) | ||
| log.debug("Wrote file directly to %s", location.uri) | ||
| log.debug(f"Successfully wrote file directly to {location.uri}") | ||
| except NotImplementedError: | ||
| with tempfile.NamedTemporaryFile(suffix=location.getExtension()) as tmpFile: | ||
| formatter._fileDescriptor.location = Location(*os.path.split(tmpFile.name)) |
There was a problem hiding this comment.
I think we also need a log message around line 225 (new) where we upload this temporary file. This is the code path that will trigger for fits files.
There was a problem hiding this comment.
Adding line 225 (new), before it attempts the put_object via a temporary file.
| @@ -113,6 +113,7 @@ def _artifact_exists(self, location: Location) -> bool: | |||
| exists : `bool` | |||
| True if the location can be found, false otherwise. | |||
| """ | |||
| log.debug(f"Checking if file exists: '{location.uri}''") | |||
There was a problem hiding this comment.
As a general comment for debug log messages we tend to use the %s deferred formatting approach following the notion that there is no point stringifying location.uri if the debug message is not going to be issued. So all these should ideally be changed to:
log.debug("something or other %s", location.uri)
hsinfang
force-pushed
the
tickets/DM-25881
branch
from
fe9ac96
to
a2aa2bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.