Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-26010: Move mypy execution to root directory, and run it on a directory. #329

Merged
merged 1 commit into from Jul 18, 2020

Conversation

TallJimbo
Copy link
Member

This is the more common and better-supported way to run mypy, but it was previously blocked by the fact that our root (lsst) package was a namespace package. This change should make no external difference in what mypy does right now, but I suspect it will be easier to maintain and I can already say it's much more compatible with at least some in-editor mypy integration tooling.

This is the more common and better-supported way to run mypy, but it
was previously blocked by the fact that our root (lsst) package was
a namespace package.  This change should make no external difference in
what mypy does right now, but I suspect it will be easier to maintain
and I can already say it's much more compatible with at least some
in-editor mypy integration tooling.
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Setuptools requiring the __init__.py was the final straw. I do wonder whether we are simply misunderstanding namespace packages or too many tools don't yet know what to do with them.

@TallJimbo
Copy link
Member Author

I do wonder whether we are simply misunderstanding namespace packages or too many tools don't yet know what to do with them.

My sense is that they are just a flawed bit of functionality - a good idea whose implementation just leaves it too hard for tools to identify when a directory is a Python package and when it isn't.

@TallJimbo TallJimbo merged commit 5dce7a7 into master Jul 18, 2020
@TallJimbo TallJimbo deleted the tickets/DM-26010 branch July 18, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants