DM-24247: Fix skypix dimension aliasing in file template validation #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stack trace should only happen if a code problem is encountered. This change ensures that we exit with bad exit status if validation fails but do not contaminate the output with a stack trace.
mypy really doesn't like try/except AttributeError so do an instance check in FileTemplate to keep it happy.
TallJimbo
approved these changes
Aug 11, 2020
There was a problem hiding this comment.
Looks good.
I gather we're just giving up on snake_case vs. camelCase consistency, at least in the CLI-facing stuff? I see both styles here, even in the same method, and I find that slightly worrying, but not enough to do more than just make sure that reflects an intentional slow transition to snake_case (in all new code? in some places?) rather than accidental.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.