Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-24575: Add some more exposure metadata fields #350

Merged
merged 2 commits into from
Aug 17, 2020
Merged

DM-24575: Add some more exposure metadata fields #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a850147
Add some more exposure metadata fields and also increment version
timj Aug 7, 2020
3c070cf
Add zenith_angle to visit and exposure
timj Aug 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
52 changes: 52 additions & 0 deletions python/lsst/daf/butler/configs/dimensions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,24 @@ dimensions:
doc: >
Average seeing, measured as the FWHM of the Gaussian with the same
effective area (arcsec).
-
name: target_name
type: string
length: 64
doc: Object of interest for this visit or survey field name.
-
name: science_program
type: string
length: 64
doc: Observing program (survey or proposal) identifier.
-
name: zenith_angle
type: float
doc: >
Approximate zenith angle in degrees during the visit.
Can only be approximate since it is continuously changing during
and observation and multiple visits can be combined from a
relatively long period.

exposure:
doc: >
Expand Down Expand Up @@ -211,6 +229,40 @@ dimensions:
doc: >
Integer group identifier associated with this exposure by the
acquisition system.
-
name: target_name
type: string
length: 64
doc: Object of interest for this observation or survey field name.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not worth fighting, because I get how ubiquitous it is... but "object" is super overloaded everywhere. Is "target" taken, or does that imply something different in an important context?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused because I made the change to target_name this morning.... Maybe I didn't push. I also added them to visit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's exactly what I did. Sorry. If you look on the obs_base ticket you'll see that it has target_name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean also to add ra/dec?

-
name: science_program
type: string
length: 64
doc: Observing program (survey or proposal) identifier.
-
name: tracking_ra
type: float
doc: >
Tracking ICRS Right Ascension of boresight in degrees. Can be NULL
for observations that are not on sky.
-
name: tracking_dec
type: float
doc: >
Tracking ICRS Declination of boresight in degrees. Can be NULL for
observations that are not on sky.
-
name: sky_angle
type: float
doc: >
Angle of the instrument focal plane on the sky in degrees. Can
be NULL for observations that are not on sky, or for observations
where the sky angle changes during the observation.
-
name: zenith_angle
type: float
doc: >
Angle in degrees from the zenith at the start of the exposure.

skymap:
doc: >
Expand Down
2 changes: 1 addition & 1 deletion python/lsst/daf/butler/registry/dimensions/static.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@


# This has to be updated on every schema change
_VERSION = VersionTuple(0, 1, 0)
_VERSION = VersionTuple(0, 2, 0)


class StaticDimensionRecordStorageManager(DimensionRecordStorageManager):
Expand Down