DM-26331: Encapsulate Timespan representations behind an ABC, other Timespan fixes/cleanup. #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-26331
branch
2 times, most recently
from
b384cc8
to
97e8314
Compare
This makes a lot of code a lot safer, as it no longer relies on a largely unenforceable convention about the ordering of fields. It also makes `DimensionRecord.fromDict` unnecessary, and hence that's being removed. Finally, while this spreads out the logic that assembles and disassembles Timespan objects and overall makes it messier, this is all in preparation for abstracting over the database representation of Timespans on a future commit, and it will make more sense then.
Trying to make this half-open (and test it against PostgreSQL operators, WIP for another commit) revealed some fundamental problems. We want this to be half-open because none of our existing use cases care about whether bounds are open or closed, but calibration collections will want to guarantee that the validity ranges for a particular dataset type and data ID are exclusive, and that's _much_ simpler if adjacent ranges do not overlap.
By testing our Timespan operators against the PostgreSQL operators for these types, we also get test coverage for Timespan, which was a bit hard to write in a non-circular way before.
This actually propagates the signature of the callable being wrapped, though it requires silencing mypy about the implementation.
TallJimbo
force-pushed
the
tickets/DM-26331
branch
from
97e8314
to
99afdb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.