Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-26415: remove chained commands from pipetask2 #359

Merged
merged 1 commit into from Aug 25, 2020
Merged

Conversation

n8pease
Copy link
Contributor

@n8pease n8pease commented Aug 22, 2020

No description provided.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor comment.

# `forward` indicates weather a subcommand should forward the value of
# this option to the next subcommand or not.
self.forward = forward
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get rid of __init__ altogether.

@n8pease n8pease merged commit f4a9c9d into master Aug 25, 2020
@timj timj deleted the tickets/DM-26415 branch February 16, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants