Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-26445: Fix Timespan equality to be fuzzy #360

Merged
merged 3 commits into from Aug 26, 2020
Merged

DM-26445: Fix Timespan equality to be fuzzy #360

merged 3 commits into from Aug 26, 2020

Conversation

timj
Copy link
Member

@timj timj commented Aug 25, 2020

No description provided.

@timj timj force-pushed the tickets/DM-26445 branch 3 times, most recently from 7e98c7a to 45b411f Compare August 26, 2020 18:03
Now reports that a timespan is equal if the delta is less than
1ns
@timj timj changed the title DM-26445: Standardize Timespan stringification and add a couple of tests DM-26445: Fix Timespan equality to be fuzzy Aug 26, 2020
Copy link
Contributor

@MichelleGower MichelleGower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String changes made debugging easier. The new fuzzy checks for equal and not equal fixed the raw ingestion problem.

@timj timj merged commit 6682cc8 into master Aug 26, 2020
@timj timj deleted the tickets/DM-26445 branch August 26, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants