DM-26620: Catch astropy.time warnings about dubious years #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any times from more than 5 years in the future will trigger warnings when converting between UTC and TAI. Catch the places where we are converting to TAI since those warnings are not relevant to users (especially when they involve MAX_TIME or simulated data from the future).
andy-slac
approved these changes
Sep 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any times from more than 5 years in the future will trigger
warnings when converting between UTC and TAI. Catch the places
where we are converting to TAI since those warnings are not
relevant to users (especially when they involve MAX_TIME
or simulated data from the future).