DM-13452: Few small fixes needed for SuperTask/QuantumGraph #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small fixes for things that I discovered while trying to implement trivial tests on SuperTask side that depend on gen3 butler interfaces.
timj
reviewed
May 7, 2018
| """A `dict` of output datasets (to be) generated for this quantum, | ||
| with the same form as `predictedInputs`. | ||
|
|
||
| Read-only; update via `addOutput()`. |
There was a problem hiding this comment.
I think you may well need two backticks here for numpydoc because it (and predictedInputs text above) are not classes. I think the alternative is to write something like ~lsst.daf.core.butler.Quantum.addOutput() (or whatever); ie give a fully qualified method name and the ~ means to truncate the output to the final element. I haven't tested this though.
There was a problem hiding this comment.
BTW, I almost literally copied docstring from other method in this class, should I change it everywhere?
There was a problem hiding this comment.
Ah. Leave it then. I'll fix it next time I try to run the doc gen and see all the warnings appear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reincarnation of #19 PR after some changes - I dropped changes to
unitsas that module disappeared.Quantumchanges are still there, and it is simple addition ofoutputsDatasetRefs. All comments regarding Quantum from old PR were taken into account. @pschella already said that Quantum changes look OK, so I'll probably just merge this unless I get more comments today-tomorrow.