Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-26680: Schema change integration branch #371

Merged
merged 28 commits into from
Sep 26, 2020
Merged

Commits on Sep 26, 2020

  1. Only query RUN collections for datasets when asked to query all.

    As all datasets are in a RUN collection, this both avoids duplicates
    and prevents triggering the limitation on CALIBRATION collections in
    queryDatasets in this common case.
    TallJimbo committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    22b8bc9 View commit details
    Browse the repository at this point in the history
  2. Add placeholder queryDatasetAssociations.

    This will ultimately need more flexibility in how to accept dataset
    constraints, rather than just pulling down everything in a dataset
    type + collection combination, but that is blocked by DM-26692.
    TallJimbo committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    1d56c6e View commit details
    Browse the repository at this point in the history
  3. Re-enable mypy on transfers code and fix breakage.

    This was accidentally disabled by moving the code out of core.
    TallJimbo committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    a1653de View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    52a2728 View commit details
    Browse the repository at this point in the history
  5. Add isCalibration flag to DatasetType.

    This allows old export files to be read, but assumes all dataset types
    in them have isCalibration=False, which may not be correct.
    TallJimbo committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    37198bc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c200378 View commit details
    Browse the repository at this point in the history
  7. Change dataset types in test data.

    The "perma" prefixes for these dataset type names made a bit of sense
    originally because they were attached to "flat" and "bias" dataset
    types that didn't have a way to be associated with a validity range
    but otherwise resembled the typical versions of those datasets.  But
    now we're changing how validity ranges are associated with datasets,
    and there will nothing to distinguish them from the usual datasets,
    and hence it makes sense to drop that prefix.
    TallJimbo committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    18d8b07 View commit details
    Browse the repository at this point in the history
  8. Remove do-nothing --output_run option from 'butler import'.

    The Butler.import_ method never uses the run passed to the Butler at
    construction, and hence it makes no sense as a command-line argument,
    let alone a required one.  Imported datasets always land in the
    collections specified in the export file.
    TallJimbo committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    a97546e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3ec859a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    fed3a65 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    461e2fd View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    7cf9f6b View commit details
    Browse the repository at this point in the history
  13. Record dynamic table name in dataset type table.

    This seems redundant right now, but it provides us some backwards
    compatibility insulation against changes to how we
    name those tables or encode dimensions in the  future.
    TallJimbo committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    40eb715 View commit details
    Browse the repository at this point in the history
  14. Switch Base64Bytes to use TEXT

    timj authored and TallJimbo committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    1b85bdc View commit details
    Browse the repository at this point in the history
  15. Add observation_reason to exposure/visit

    timj authored and TallJimbo committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    b762450 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    9de47c6 View commit details
    Browse the repository at this point in the history
  17. Change nomenclature for association tables in dataset managers.

    There will soon be at least one more kind of dynamic table, so
    that's no longer an appropriate name for this one.
    TallJimbo committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    c196d6d View commit details
    Browse the repository at this point in the history
  18. Remove test for exceeding string length

    Now that most fields are TEXT the test is meaningless.
    timj authored and TallJimbo committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    5d83b15 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    de49ff8 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    08258cd View commit details
    Browse the repository at this point in the history
  21. Add CALIBRATION-type collections.

    General query support for these collections does not yet exist, but is
    blocked by a bigger overhaul of the query system; we'll work around
    this in QuantumGraph generation in pipe_base for now.
    TallJimbo committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    9ebcc53 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    739c063 View commit details
    Browse the repository at this point in the history
  23. Include DatasetType.isCalibration() in __eq__, __repr__.

    This helps us spot and report inconsistent definitions in
    PipelineTasks.
    TallJimbo committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    3fa4566 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    2b8ade7 View commit details
    Browse the repository at this point in the history
  25. Support calibration indirection directly in butler.get.

    I'm not certain this is the right place for this logic, but the
    huge simplification it provides for ci_cpp_gen3 tests (which will carry
    over directly to interactive CPP validation work) suggests that it
    belongs somewhere in daf_butler.
    TallJimbo committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    2062a8d View commit details
    Browse the repository at this point in the history
  26. Update version numbers

    timj authored and TallJimbo committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    4578e4c View commit details
    Browse the repository at this point in the history
  27. Merge pull request #380 from lsst/tickets/DM-26629

    DM-26629: switch to calibration collections and remove calibration_label
    TallJimbo committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    a4b6f67 View commit details
    Browse the repository at this point in the history
  28. Increment version numbers (again).

    This ideally would have been merged with the previous version update
    prior to the DM-26629 merge, but I forgot, that merge has happened,
    and so have other DM-26629 merges to master, so it's time to get this
    branch on master, too.
    TallJimbo committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    f415ca5 View commit details
    Browse the repository at this point in the history