Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-26684: Add command-line tool for Butler.pruneCollection #373

Merged
merged 3 commits into from Sep 16, 2020

Conversation

n8pease
Copy link
Contributor

@n8pease n8pease commented Sep 14, 2020

No description provided.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but can we have a test that it's actually deleting a collection? ie delete a collection and then show that queryCollections doesn't list it any more.

__all__ = ["butler_import", "create", "config_dump", "config_validate", "query_collections",
"query_dataset_types"]
__all__ = ["butler_import", "create", "config_dump", "config_validate", "prune_collection",
"query_collections", "query_dataset_types"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might make future changes easier if you make one per line so that a new one early in the alphabet doesn't cause multiple lines to reflow.



from .commands import (butler_import, create, config_dump, config_validate, query_collections,
query_dataset_types)
from .commands import (butler_import, create, config_dump, config_validate, prune_collection,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar comment about one per line here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants