-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-26683: Make exporting dimension data friendlier #375
Commits on Sep 16, 2020
-
Improve type annotations on immutable decorator.
Without generics, decoration hid all type information about the wrapped type.
Configuration menu - View commit details
-
Copy full SHA for 0c3ddb0 - Browse repository at this point
Copy the full SHA 0c3ddb0View commit details -
Fix inf recursion DimensionUniverse.__repr__.
This was a relic from when DimensionUniverse inherited from DimensionGraph and DimensionGraph defined __str__.
Configuration menu - View commit details
-
Copy full SHA for 5578084 - Browse repository at this point
Copy the full SHA 5578084View commit details -
Move repository import/export code into separate package.
This should not change functionality at all; it's just moving code around. A separate package gives the code a bit more room for expansion and more clearly separates between interfaces and implementations. Moving it out of 'core' fixes the existing circular dependency issues: the import/export code needs to depend on both Registry and Datastore, and hence shouldn't go in core. But the registry tests depend on it, so there is one new circular dependency in registry.tests, but because tests conceptually depend on everything I'm not bothered by this (maybe we should have named that 'registry_tests' instead of making it a registry subpackage, but I'm not going to).
Configuration menu - View commit details
-
Copy full SHA for d062e3e - Browse repository at this point
Copy the full SHA d062e3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2031534 - Browse repository at this point
Copy the full SHA 2031534View commit details -
Defer export writes in order to deduplicate dimension records.
This should address the core complaint of DM-26683.
Configuration menu - View commit details
-
Copy full SHA for 0c3008f - Browse repository at this point
Copy the full SHA 0c3008fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b3ce605 - Browse repository at this point
Copy the full SHA b3ce605View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35d518c - Browse repository at this point
Copy the full SHA 35d518cView commit details -
Make element argument in RepoExportContext more user-friendly.
Strings are now accepted as well as DimensionElement instances, and passing elements without tables (like 'htmN') is now correctly ignored (because the user shouldn't care which elements have tables).
Configuration menu - View commit details
-
Copy full SHA for 7baced3 - Browse repository at this point
Copy the full SHA 7baced3View commit details
Commits on Sep 17, 2020
-
Remove/adjust confusing comments in butler tests.
I wrote these a year ago and don't understand them anymore.
Configuration menu - View commit details
-
Copy full SHA for b10c432 - Browse repository at this point
Copy the full SHA b10c432View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7eef36c - Browse repository at this point
Copy the full SHA 7eef36cView commit details