DM-26600: Add ability to remove a dataset type #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-26600
branch
from
db12e4c
to
c806e0c
Compare
timj
commented
Sep 23, 2020
python/lsst/daf/butler/registry/datasets/byDimensions/_manager.py
Outdated
Show resolved
Hide resolved
python/lsst/daf/butler/registry/datasets/byDimensions/_manager.py
Outdated
Show resolved
Hide resolved
python/lsst/daf/butler/registry/datasets/byDimensions/_manager.py
Outdated
Show resolved
Hide resolved
python/lsst/daf/butler/registry/datasets/byDimensions/_manager.py
Outdated
Show resolved
Hide resolved
timj
force-pushed
the
tickets/DM-26600
branch
from
c806e0c
to
cc5d148
Compare
TallJimbo
approved these changes
Sep 23, 2020
python/lsst/daf/butler/registry/datasets/byDimensions/_manager.py
Outdated
Show resolved
Hide resolved
python/lsst/daf/butler/registry/datasets/byDimensions/_manager.py
Outdated
Show resolved
Hide resolved
python/lsst/daf/butler/registry/datasets/byDimensions/_manager.py
Outdated
Show resolved
Hide resolved
python/lsst/daf/butler/registry/datasets/byDimensions/_manager.py
Outdated
Show resolved
Hide resolved
tests/test_butler.py
Outdated
|
|
||
| # Try and fail to delete a datasetType that is associated with data | ||
| with self.assertRaises(Exception): | ||
| butler.registry.pruneDatasetType(datasetType.name) |
There was a problem hiding this comment.
If you can think of an easy way to do it, it'd also be nice to check here that nothing did get deleted. I'm not at all worried about the current implementation, but a different caching model might lead to an implementation where that's less obvious.
andy-slac
approved these changes
Sep 24, 2020
python/lsst/daf/butler/registry/datasets/byDimensions/_manager.py
Outdated
Show resolved
Hide resolved
timj
force-pushed
the
tickets/DM-26600
branch
4 times, most recently
from
d4a1666
to
895bd07
Compare
timj
force-pushed
the
tickets/DM-26600
branch
from
895bd07
to
5198b6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.