DM-26371: Make Quantum immutable #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
changed the title
TallJimbo
reviewed
Sep 25, 2020
| @@ -165,7 +131,7 @@ def initInputs(self) -> NamedKeyDict[DatasetType, DatasetRef]: | |||
| with `DatasetType` instances as keys (names can also be used for | |||
| lookups) and `DatasetRef` instances as values. | |||
| """ | |||
| return self._initInputs | |||
| return copy.copy(self._initInputs) | |||
There was a problem hiding this comment.
Check out NamedKeyDict.freeze; I think it's exactly what you want here and in similar accessors (or maybe the constructor). That'd come with changing the return type NamedKeyMapping[DatasetType, DatasetRef].
andy-slac
approved these changes
Sep 25, 2020
andy-slac
reviewed
Sep 25, 2020
| @@ -99,39 +84,26 @@ class Quantum: | |||
| def __init__(self, *, taskName: Optional[str] = None, | |||
| taskClass: Optional[Type] = None, | |||
| dataId: Optional[DataCoordinate] = None, | |||
| run: Optional[str] = None, | |||
| initInputs: Optional[Union[Mapping[DatasetType, DatasetRef], Iterable[DatasetRef]]] = None, | |||
| predictedInputs: Optional[Mapping[DatasetType, List[DatasetRef]]] = None, | |||
There was a problem hiding this comment.
With dropping actualInputs would it make sense to call it inputs instead of predictedInputs?
Remove all the properties of Quantum that were expected to be mutable. Make sure object was then immutable. Add a hash and eq function based on immutable instance attributes.
natelust
force-pushed
the
tickets/DM-26371
branch
from
6d28b8e
to
8033b6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all the properties of Quantum that were expected to be
mutable. Make sure object was then immutable. Add a hash and
eq function based on immutable instance attributes.