DM-26947: generalize test support code and add test for Butler.get on calibrations #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
reviewed
Sep 28, 2020
tests/test_simpleButler.py
Outdated
| helper._finish() | ||
| def makeButler(self, **kwargs: Any) -> Butler: | ||
| config = ButlerConfig() | ||
| config["registry", "db"] = "sqlite://" |
There was a problem hiding this comment.
It might be clearer here if you use :memory: explicitly here like is done in https://github.com/lsst/daf_butler/blob/master/python/lsst/daf/butler/tests/_testRepo.py#L76
TallJimbo
force-pushed
the
tickets/DM-26947
branch
from
c7027da
to
6379be5
Compare
This renames test_transfers.py to test_simpleButler.py, and modifies its test infrastructure to create and use Butler objects instead of duplicating some of Butler's logic. I think this will be a better place than test_butler.py to put some other new butler tests (and maybe some old ones, too) for a few reasons: - it provides a way to avoid combinatorial testing of butler configurations when that isn't justified; - it tests the default configuration of butler, not the test configurations; - it provides a way to use the tests/data/registry yaml export files to set up test data.
TallJimbo
force-pushed
the
tickets/DM-26947
branch
from
6379be5
to
c4c60cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to ask for a review of 2062a8d when I added it to DM-26629 after the main review for that ticket was complete. This branch address two obvious problems with that commit - lack of docs and tests - already, but I'd like to have that commit reviewed here as well as the code actually on this branch.