DM-26405: Move S3-backoff into actual S3 class #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubarwrangler
changed the title
fubarwrangler
changed the title
ktlim
approved these changes
Nov 4, 2020
fubarwrangler
force-pushed
the
tickets/DM-26405
branch
from
d3bd063
to
be90613
Compare
|
Rebased onto master, awaiting tests. Then I will merge. |
added 3 commits
November 4, 2020 14:25
Some question on which methods get all_errors or just client_errors for backoff. Also question in JIRA about why not use boto3 native backoff? For now this at least passes tests...
timj
force-pushed
the
tickets/DM-26405
branch
from
be90613
to
34bee24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some question on which methods get all_errors or just client_errors for
backoff. For now this at least passes tests...