DM-27427: Raise an exception if trying to find datasets but we know we'll fail. #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
changed the title
erykoff
approved these changes
Nov 4, 2020
| "it is impossible for any such datasets to be found in any of those collections, " | ||
| "most likely because the dataset type is not registered. " | ||
| "That this error may become a successful query that returns no results in the future, " | ||
| "because queries with no results are not usually considered an error." |
There was a problem hiding this comment.
Should this be "Note that this error..."? As it is, the second sentence doesn't scan.
The right solution is to return a QueryResult-like object with no result rows that isn't actually backed by a database query, but this should improve the error message in the meantime.
TallJimbo
force-pushed
the
tickets/DM-27427
branch
from
941d8e1
to
1ee17f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The right solution is to return a QueryResult-like object with no result rows that isn't actually backed by a database query, but this should improve the error message in the meantime.