DM-27418: Use safe_load/dump for YAML #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-27418
branch
2 times, most recently
from
8e9ebec
to
aea5c60
Compare
TallJimbo
approved these changes
Nov 4, 2020
ktlim
approved these changes
Nov 4, 2020
Previously if an earlier test in the loop failed by definition all tests would fail after that because a dataset would exist that could not be replaced. Now each time round the loop a new tag/collection is used so even if one fails the next attempts (and the attempt outside the loop) will not be affected.
It was never relocated to the _toBytes method when the class was reorganized so in some code paths we were writing out YAML or JSON with native python classes defined.
It was confusing to convert a YAML/JSON parse error to None and then assume that nothing was read. This moved the error message to a location that made no sense. Now allow the formatter to report the parse error directly.
This ensures that people only use this default formatter for data structures that we can trust.
This works fine for things like PropertyList where safe_load will read it back because of the registered representers. If an unscrupulous user enables it for something that has not been properly setup for yaml serialization then the subsequent safe_load will fail on read.
timj
force-pushed
the
tickets/DM-27418
branch
from
aea5c60
to
477dcae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are also some other fixes here that came about when debugging the YAML change.