DM-27435: Unification of file-like datastores #426
Conversation
timj
force-pushed
the
tickets/DM-27435
branch
3 times, most recently
from
f855017
to
22d5443
Compare
| # There will be problems with the bytes we are supplying so ignore | ||
| pass | ||
| return True | ||
|
|
There was a problem hiding this comment.
Is the long-term plan here to implement this in subclasses directly, and then make it abstract?
There was a problem hiding this comment.
Yes. I haven't worked out the best approach yet but there is a Formatter cleanup ticket. I wanted an API here though so that I could at least ask the formatter about it even if the implementation was a bit odd. I had hoped to get away with always using the presence of a method to declare it but it seems like I'm going to have to use the approach of a class property and implementation method.
| with uri.as_local() as local_uri: | ||
| # Have to update the Location associated with the formatter | ||
| # because formatter.read does not allow an override. | ||
| # This could be improved. |
There was a problem hiding this comment.
FWIW, this is indeed something I'd love to see fixed (but not on this ticket).
There was a problem hiding this comment.
The FileDescriptor class was one of the first classes that Pim wrote and I'm not really convinced I need it. Again I can deal with that on the formatter cleanup.
timj
force-pushed
the
tickets/DM-27435
branch
3 times, most recently
from
7e9a9f1
to
5fc9708
Compare
They are now deprecated and replaced by RemoteFileDatastore
This lets a URI from a temporary file be marked as such so that users can make decisions (for example when deciding whether certain transfer modes make sense).
This will save people from doing a check on the URI scheme
This allows temporary files to be deleted automatically.
The file reader had this logic but the bytes handler did not.
The implementation is not perfect since it relies on a method raising NotImplementedError since at the moment there is no class property to simply declare bytes support.
* PosixDatastore and RemoteFileDatastore now issued deprecation warnings.
Now has a context manager rather than directly changing the internal property of the formatter.
Nothing ever used it directly so it can be safely removed without a deprecation period.
timj
force-pushed
the
tickets/DM-27435
branch
from
bd5812e
to
19300f8
Compare
No description provided.