Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-27490: Add support for collection docstrings. #430

Merged
merged 1 commit into from Nov 11, 2020
Merged

Conversation

TallJimbo
Copy link
Member

No description provided.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. One question.

name : `str`
Name of the collection.
docs : `str`, optional
Docstring for the collection with the given name.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you set doc to None here does it remove the existing docstring? Maybe state that this value overwrites a previous value?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should remove the existing docstring. I'll update the docstring and add a test to make sure it's not lying.

@TallJimbo TallJimbo merged commit e1fa02c into master Nov 11, 2020
@TallJimbo TallJimbo deleted the tickets/DM-27490 branch November 11, 2020 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants