-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-27154: Usability improvement suggestions for butler collection commands #431
Merged
Commits on Nov 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ff087d2 - Browse repository at this point
Copy the full SHA ff087d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e74bca9 - Browse repository at this point
Copy the full SHA e74bca9View commit details
Commits on Nov 16, 2020
-
improve 'prune-collections' arg error reporting
Adds an execption type (inherits from TypeError) for the ways arguments to Butler.pruneCollections can fail. This allows the CLI script function to catch the exception, know the reason for the failure, and format a message to report the error in a way that will make sense on the command line. If this seems like an acceptible solution to reviewers this pattern may be used elsewhere to improve CLI error reporting as needed.
Configuration menu - View commit details
-
Copy full SHA for a2be792 - Browse repository at this point
Copy the full SHA a2be792View commit details -
add --chains option to query-collections
Adds various ways of formatting the collections.
Configuration menu - View commit details
-
Copy full SHA for f6cab84 - Browse repository at this point
Copy the full SHA f6cab84View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad52f00 - Browse repository at this point
Copy the full SHA ad52f00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a4808a - Browse repository at this point
Copy the full SHA 4a4808aView commit details -
Puts duplicated test repo code for the various CLI tests in a shared location & adds some API for modifying the repo.
Configuration menu - View commit details
-
Copy full SHA for f714b55 - Browse repository at this point
Copy the full SHA f714b55View commit details -
make collection chain a string early
Numpy recently added a deprecation warning for "ragged" arrays; in this case it was ragged because of a type mismatch; CollectionSearch vs str. Making the CollectionSearch a string in the list comprehension prevents us from encountering the warning.
Configuration menu - View commit details
-
Copy full SHA for 13475bb - Browse repository at this point
Copy the full SHA 13475bbView commit details -
removes use of @patch, and just replaces mocked functions.
Configuration menu - View commit details
-
Copy full SHA for 5e9389d - Browse repository at this point
Copy the full SHA 5e9389dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.