Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-27154: Usability improvement suggestions for butler collection commands #431

Merged
merged 9 commits into from
Nov 17, 2020

Commits on Nov 13, 2020

  1. alphabatize shared arguments

    n8pease committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    ff087d2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e74bca9 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2020

  1. improve 'prune-collections' arg error reporting

    Adds an execption type (inherits from TypeError) for the ways
    arguments to Butler.pruneCollections can fail. This allows the
    CLI script function to catch the exception, know the reason for
    the failure, and format a message to report the error in a way
    that will make sense on the command line.
    If this seems like an acceptible solution to reviewers this pattern
    may be used elsewhere to improve CLI error reporting as needed.
    n8pease committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    a2be792 View commit details
    Browse the repository at this point in the history
  2. add --chains option to query-collections

    Adds various ways of formatting the collections.
    n8pease committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    f6cab84 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ad52f00 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4a4808a View commit details
    Browse the repository at this point in the history
  5. make a test repo manager

    Puts duplicated test repo code for the various CLI tests in a
    shared location & adds some API for modifying the repo.
    n8pease committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    f714b55 View commit details
    Browse the repository at this point in the history
  6. make collection chain a string early

    Numpy recently added a deprecation warning for "ragged" arrays;
    in this case it was ragged because of a type mismatch;
    CollectionSearch vs str. Making the CollectionSearch a string
    in the list comprehension prevents us from encountering the
    warning.
    n8pease committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    13475bb View commit details
    Browse the repository at this point in the history
  7. deduplciate mock code

    removes use of @patch, and just replaces mocked functions.
    n8pease committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    5e9389d View commit details
    Browse the repository at this point in the history