DM-27118: Add support for recreating logging configuration #439
Conversation
New pipetask option for multiprocessing spawn method needs support for transporting global state from parent to child processes. Logging configuration is a part of this global state, this commit adds support for recording and replaying logging configuration changes.
| # execute each one in order | ||
| for call in configState: | ||
| method, *args = call | ||
| method(*args) |
There was a problem hiding this comment.
why not use functools.partial? (binding arg vals to funcs is what it's made for)
There was a problem hiding this comment.
I thought about that but decided that I want to avoid extra imports and complexity. There are certainly cases when partial is useful, but in this case it's easy to do things without it.
python/lsst/daf/butler/cli/cliLog.py
Outdated
| """ | ||
| if cls._initialized or cls.configState: | ||
| # Already initialized, do not touch anything. | ||
| log = logging.getLogger(__name__.partition(".")[2]) |
There was a problem hiding this comment.
In all other butler code we use __name__ and don't strip the lsst. (I see it's actually two places because something else crept in as well)
There was a problem hiding this comment.
I'm trying to follow recommendations that say lsst should be dropped: https://developer.lsst.io/stack/logging.html#logger-names. I can certainly change that to just __name__ if this is preferred.
There was a problem hiding this comment.
butler is special and has been for a long time -- if you drop it people will have to use lsst.daf.butler and daf.butler to turn on debug logging .
There was a problem hiding this comment.
OK, I'll replace that and other cases if I find any.
There was a problem hiding this comment.
The only other one was in core/utils.py I think
There was a problem hiding this comment.
Replaced 3 instances in a new commit.
andy-slac
changed the title
New pipetask option for multiprocessing spawn method needs support for
transporting global state from parent to child processes. Logging
configuration is a part of this global state, this commit adds support
for recording and replaying logging configuration changes.