Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-27685 Add butler make gen3 dcr subfilters subcommand #449

Merged
merged 1 commit into from Dec 14, 2020

Conversation

n8pease
Copy link
Contributor

@n8pease n8pease commented Dec 8, 2020

When the command funciton docstring spanned multiple lines the
argument help text was getting inserted into the middle of the
command function text.

Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in commit message.

if len(doclines) > 1 and doclines[1]:
doclines[0] = " ".join((doclines[0], doclines.pop(1).strip()))
else:
break
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this could just be

while len(doclines) > 1 and doclines[1]:
    doclines[0] = " ".join((doclines[0], doclines.pop(1).strip()))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one.

When the command funciton docstring spanned multiple lines the
argument help text was getting inserted into the middle of the
command function text.
@n8pease n8pease merged commit 91d8f7d into master Dec 14, 2020
@timj timj deleted the tickets/DM-27685 branch February 16, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants