DM-26688: Add command-line tool for Registry.associate #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This work is built on top of the branch tickets/DM-26689, it will get checked in after that one. |
TallJimbo
approved these changes
Jan 13, 2021
| butler = Butler(repo, writeable=True) | ||
|
|
||
| if butler.registry.getCollectionType(collection) is not CollectionType.CHAINED: | ||
| raise RuntimeError("Can only add datasets to a chained collection.") |
There was a problem hiding this comment.
Instead of this check, let's do
butler.registry.registerCollection(collection, CollectionType.TAGGED)
- This will create the collection if it does not exist, which will be very convenient, and it will raise an exception if it exists with the wrong type.
- The type needs to be
TAGGED, notCHAINED
| find_first=find_first, | ||
| show_uri=False, | ||
| repo=None | ||
| ) |
There was a problem hiding this comment.
I like the idea of calling the script rather than the native method to share logic like transforming globs to regexes. Do we need to worry about the script also doing unnecessary things (like making astropy Tables) at all?
There was a problem hiding this comment.
QueryDatasets generates astropy tables on demand via the getter (getTables), so it's structured to not create these if they're not needed. (I do see a mistake in passing the QueryDatasets results to the butler without using the accessor, will fix)
n8pease
force-pushed
the
tickets/DM-26688
branch
from
4efd618
to
3f709d7
Compare
n8pease
force-pushed
the
tickets/DM-26689
branch
from
e55d966
to
7829756
Compare
n8pease
force-pushed
the
tickets/DM-26689
branch
2 times, most recently
from
2fb787d
to
18a095a
Compare
n8pease
force-pushed
the
tickets/DM-26688
branch
5 times, most recently
from
6d683fd
to
1419c4d
Compare
This allows reuse of the options that are needed to call query datasets.
n8pease
force-pushed
the
tickets/DM-26688
branch
from
1419c4d
to
a0b9141
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.