DM-28674: Allow # to mean fragment in schemeless URIs #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we always escaped # but for quantum graph subsetting it makes sense to allow # generally for all URIs. This change assumes that # in the directory part of the filename should not be treated as fragments.
This will confuse URI handlers in some cases and it's safer to disallow it.
natelust
approved these changes
Feb 5, 2021
| head, tail = os.path.split(output) | ||
| output = os.path.join(head, tail.replace(".", "_")) | ||
| tail = tail.replace(".", "_") | ||
| tail = tail.replace("#", "HASH") |
There was a problem hiding this comment.
We probably dont care about speed here (at the number of times this will be called its negligible), and what is more readable probably depends on who reads it, but FWIW, tail.replace(".", "_").replace("#", "HASH") is a bit faster (I personally find it easier to grok, but others might not). This is more a side comment and not an explicit request to change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.