Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-27473: Update Config.merge to support dict as well as Config #470

Merged
merged 1 commit into from Feb 8, 2021
Merged

DM-27473: Update Config.merge to support dict as well as Config #470

merged 1 commit into from Feb 8, 2021

Conversation

timj
Copy link
Member

@timj timj commented Feb 5, 2021

No description provided.

MichelleGower
MichelleGower approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@MichelleGower MichelleGower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about Exception type and some comments about the test case. Approved for merging.

tests/test_config.py Outdated Show resolved Hide resolved
tests/test_config.py Show resolved Hide resolved
python/lsst/daf/butler/core/config.py Outdated Show resolved Hide resolved
@timj timj merged commit 509ddab into master Feb 8, 2021
@timj timj deleted the tickets/DM-27473 branch February 8, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelleGower MichelleGower MichelleGower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @MichelleGower