Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-28583: require data ID when constructing a formatter #476

Merged
merged 2 commits into from Feb 18, 2021
Merged

DM-28583: require data ID when constructing a formatter #476

merged 2 commits into from Feb 18, 2021

Conversation

TallJimbo
Copy link
Member

No description provided.

parejkoj
parejkoj approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to trust you on this being a necessary change here. Fewer optional parameters is usually a good thing anyway.

@timj timj mentioned this pull request Feb 17, 2021
Merged
@parejkoj parejkoj merged commit a40c7d7 into master Feb 18, 2021
@parejkoj parejkoj deleted the tickets/DM-28583 branch February 18, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parejkoj parejkoj parejkoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TallJimbo @parejkoj